We haven’t seen any flood of reports that would suggest using OneDrive is a bad choice. You may wish to consider disabling the “Files On-Demand” feature, which has the potential for removing Scrivener project resources from your disk, but a user report suggested that even with it on, and with Scrivener files missing, it is safe to use, because the way it works is by acting like a “slow drive” while they download in the background. Thus a project that is somewhat “offline” will just load a little more slowly the very first time. If this is true, then as I said in that thread, that is exactly how these kinds of sync features should be implemented. In the past they were awful, and would result in panic because you’d load a project and half of it would appear missing.
I see that scrivener is recommending to use dropbox to sync projects across computers or platforms.
I don’t know where that is said. It may be a confusion between how the iOS version only supports the Dropbox API at this time. Scrivener between desktops though can in theory work with just about any sync tool, so long as it knows what a file and a folder is, and how to put one into the other. 
The only one we know of that causes real problems is Google Drive.